From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 10 May 2016 05:59:35 GMT
Subject: Re: What's cooking in git.git (May 2016, #02; Fri, 6)
Message-ID: <alpine.DEB.2.20.1605100757410.4092@virtualbox>
In-Reply-To: <xmqqeg9e24ay.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Fri, 6 May 2016, Junio C Hamano wrote:

> * jc/fsck-nul-in-commit (2016-04-14) 2 commits
>  - fsck: detect and warn a commit with embedded NUL
>  - fsck_commit_buffer(): do not special case the last validation
> 
>  "git fsck" learned to catch NUL byte in a commit object as
>  potential error and warn.
> 
>  What was the status of this one?  Ready to proceed?

I think this code looks fine. Maybe two comments on the test:

>               test_must_fail git -c fsck.nulInCommit=error fsck 2>warn.1 &&
>               git fsck 2>warn.2 &&
>               grep nulInCommit warn.2

1) warn.1 is not used. Maybe skip that redirection?

2) I was under the impression that we preferred test_i18ngrep over grep...

Thanks,
Dscho