From: Johannes Schindelin Date: Wed, 04 May 2016 11:25:20 GMT Subject: Re: [PATCH] submodule: stop sanitizing config options Message-ID: In-Reply-To: Hi, On Wed, 4 May 2016, Junio C Hamano wrote: > Jeff King writes: > > > [+cc Stefan and Jacob since this is really resuming that earlier thread] > > ... > >> > >> So I think we'd actually want my series as a preliminary fix, followed > >> by dropping the whitelist entirely on top of that, and then probably > >> simplifying the shell sanitize_submodule_env() on top of that (it would > >> be correct without the whitelist, but you can also trivially implement > >> it without having to call submodule--helper at all). > > > > I think we'd actually do it all in one, and that patch looks something > > like the one below (on top of jk/submodule-config-sanitize-fix). > > > > I don't feel that strongly about going either direction with this, but I > > figure it doesn't hurt to make the patch so we know what the actual > > option looks like. > > I do not feel strongly either, but I suspect "we do not filter" > would be a lot easier to explain than "we pass these selected > things, each with such and such justification why it has to be > passed down". I really like the simplicity of the rationale. > Nice code reduction is very attractive, too, but that is secondary. Me, too. It just makes things simpler. Ciao, Dscho