From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 28 Apr 2016 14:02:07 GMT
Subject: Re: [PATCH 0/5] fixes for sanitized submodule config
Message-ID: <alpine.DEB.2.20.1604281600020.9313@virtualbox>
In-Reply-To: <20160428133534.GA19056@sigill.intra.peff.net>

Hi Peff,

On Thu, 28 Apr 2016, Jeff King wrote:

> On Thu, Apr 28, 2016 at 08:17:53AM -0400, Jeff King wrote:
> 
> > So that case _is_ correct right now. It's just that t5550 isn't testing
> > the shell script part, which is broken. Probably running "git submodule
> > update" in the resulting clone would cover that.
> > 
> > And for the fetch case, we probably just need to be calling
> > prepare_submodule_repo_env() there, too.
> 
> So here's a series which fixes sanitizing in the "git-submodule" shell
> script, along with "git fetch". And cleans up a few things along the
> way.

Nice!

I reviewed those changes and they all look sensible to me (did not apply
them locally for lack of time, though).

Ciao,
Dscho