From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 20 Apr 2016 06:37:21 GMT
Subject: Re: [PATCH] replace --edit: respect core.editor
Message-ID: <alpine.DEB.2.20.1604200836050.2826@virtualbox>
In-Reply-To: <CAP8UFD189+AcLstEx4s_2ZYWp6UOtDb=vWGYhCpJayM8ma5hxw@mail.gmail.com>

Hi Christian & Peff,

On Wed, 20 Apr 2016, Christian Couder wrote:

> On Wed, Apr 20, 2016 at 5:53 AM, Jeff King <peff@peff.net> wrote:
> > On Tue, Apr 19, 2016 at 09:22:37AM -0700, Junio C Hamano wrote:
> >
> >> I can understand "we only know edit mode needs config, and we know it
> >> will never affect other modes to have the new call here", and it
> >> would be good for an emergency patch for ancient maintenance track
> >> that will not get any other changes or enhancements.  I do not think
> >> it is a sound reasoning to maintain the codefor the longer term,
> >> though.
> >
> > Yeah. I agree the patch here is not wrong, but I would prefer to just
> > have git-replace load the config when it starts. It's _possible_ that
> > something might break or misbehave, but IMHO any program which breaks
> > when git_default_config() is run is probably in need of fixing.
> 
> I agree.

Okay. I tried to err on the side of caution (side effects? Ever heard of
side effects? ;-))

v2 coming.

Ciao,
Dscho