From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 13 Jan 2016 07:40:12 GMT
Subject: Re: [PATCH v4 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease
Message-ID: <alpine.DEB.2.20.1601130838430.2964@virtualbox>
In-Reply-To: <5695A077.7070606@ramsayjones.plus.com>

Hi Ramsay,

On Wed, 13 Jan 2016, Ramsay Jones wrote:

> Also, when compiling on Cygwin with NO_LIBGEN_H, I need to
> include the following here:
> 
> #undef basename
> 
> in order to suppress approx 230 warnings about the redefinition
> of the basename macro.
> 
> (I suppose that should go in the previous commit. dunno)

I think this is an incorrect use of NO_LIBGEN_H (because Cygwin obviously
has it), but in any case, it is a completely independent issue from
fixing/testing basename()/dirname(), so your #undef basename should be in
a completely separate commit, methinks.

Ciao,
Dscho