From: Peter Krefting <peter@softwolves.pp.se>
Date: Thu, 07 Aug 2014 07:16:23 GMT
Subject: Re: [PATCH v2 02/23] rebase -i: allow squashing empty commits without complaints
Message-ID: <alpine.DEB.2.00.1408070814230.18704@ds9.cixit.se>
In-Reply-To: <16751a4402233b6c2925bf00d7ecebdccedd0eef.1407368621.git.bafain@gmail.com>

Fabian Ruch:

>>   2. Notice ourselves that the end-result of the whole squash is an
>>      empty commit, and stop to let the user deal with it.
>
> This patch chooses the second alternative. Either way seems OK. The 
> crucial consensus of the discussion was to silently throw away empty 
> interim commits.

Yes, the important part is that giving good advice is better than 
giving bad advice. Thank you for taking your time to fix this.

I haven't reviewed the changes themselves, but I am happy with the 
underlying idea.

-- 
\\// Peter - http://www.softwolves.pp.se/