From: Peter Krefting <peter@softwolves.pp.se>
Date: Mon, 05 Aug 2013 12:48:28 GMT
Subject: Re: [PATCH] commit: reject non-characters
Message-ID: <alpine.DEB.2.00.1308051346530.3657@ds9.cixit.se>
In-Reply-To: <alpine.DEB.2.00.1307091213090.2313@ds9.cixit.se>

Peter Krefting:

> -		/* U+FFFE and U+FFFF are guaranteed non-characters. */
> -		if ((codepoint & 0x1ffffe) == 0xfffe)
> +		/* U+xxFFFE and U+xxFFFF are guaranteed non-characters. */
> +		if ((codepoint & 0xffffe) == 0xfffe)
> +			return bad_offset;

Drats, there is an F too many in the bitmask, it should be:

  +		if ((codepoint & 0xfffe) == 0xfffe)

-- 
\\// Peter - http://www.softwolves.pp.se/