From: Peter Krefting Date: Thu, 23 Feb 2012 11:25:21 GMT Subject: Re: [PATCH 2/4] Do attempt pretty print in ASCII-incompatible encodings Message-ID: In-Reply-To: <20120221182118.GA32668@sigill.intra.peff.net> Jeff King: > I'm not sure why we bother checking this. Using non-ASCII-superset > encodings is broken, yes, but are people actually doing that? [...] > Are there actually encodings that will cause subtle breakage that we want > to catch? Shift-JIS could be a problem; if implemented to the letter it would convert 0x5C to a Yen character and 0x7E as an overline. Otherwise I expect it only being a problem with ISO 646 encodings, especially the ones that replace "@" with something else [1]. Also any ISO 2022 seven-bit encoding (ISO-2022-{CN,JP,KR}) could cause problems, especially if there is any preprocessing done on the string that does not respect its state-shifting (most 0x21--0x7E characters can be lead and trail bytes in their multi-byte modes). -- \\// Peter - http://www.softwolves.pp.se/ [1] Trying to send Internet e-mail from a system using the extended Swedish seven-bit encoding, where 0x40 mapped to "É", could sometimes be a challenge.