From: Peter Krefting <peter@softwolves.pp.se>
Date: Tue, 16 Nov 2010 20:10:03 GMT
Subject: Re: [PATCH 1/2] [RFC] Detect attempts at calling git init specifying a remote repository.
Message-ID: <alpine.DEB.2.00.1011162107580.13543@perkele.intern.softwolves.pp.se>
In-Reply-To: <7vfwv1i22u.fsf@alter.siamese.dyndns.org>

Junio C Hamano:

>> --- a/builtin/init-db.c
>> +++ b/builtin/init-db.c
>> @@ -435,7 +435,12 @@ int cmd_init_db(int argc, const char **argv, const char *prefix)
>>  		int mkdir_tried = 0;
>>  	retry:
>>  		if (chdir(argv[0]) < 0) {
>> -			if (!mkdir_tried) {
>> +			if (is_url(argv[0]) || strchr(argv[0], '@') != NULL || (strchr(argv[0], ':') != NULL && !has_dos_drive_prefix(argv[0]))) {
>> +				/*
>> +				 * We were passed a remote repository specification.
> Or a directory with ':' in its pathname, no?

Indeed. Don't do that, then :-)

Seriously, though, I tried finding an API that checked if the pathspec is 
local or remote, but I was unable to. Is there one I should use instead?

-- 
\\// Peter - http://www.softwolves.pp.se/