From: Peter Krefting Date: Mon, 13 Sep 2010 07:15:48 GMT Subject: Re: [PATCH 2/2] Add Swedish translation. Message-ID: In-Reply-To: Ævar Arnfjörð Bjarmason: > * Doesn't follow the "Initializing a .po file" docs in > t/README. Here's what you get after applying the little Perl > cleanup program there to it: Well, I just used the standard commands for creating it. > @@ -1,54 +1,38 @@ > -# Swedish translation of git > -# Copyright © 2010 Peter krefting > -# Peter Krefting , 2010. > -# That's a standard header, which is good to keep for clarity. If we want to go through Translation Project (which I still do recommend), it is required. > -"PO-Revision-Date: 2010-09-12 21:07+0100\n" That's a good reference header to see how out-of-date the translation is. > -"Last-Translator: Peter Krefting \n" > -"Language-Team: Swedish \n" These are standard headers to make it easier to find out who to blame the translation on. I haven't actually submitted my translation for review on the Swedish list yet, but will do so soon enough. > -#: wt-status.c:56 These context lines are invaluable when figuring out how to translate stuff, and to track back strings after the fact. I do not like the idea of removing them. > * Commit message should be "po/sv.po: add Swedish translation". It > makes it much easier to `git log --grep=po/` or `git log > --grep=po/sv.po` in the future. Git has that information already, no need to put it in the commit message :-) > * You're translating the TEST: messages, it's redundant except for > Icelandic (which uses it for git.git tests), but I can see how it > can be painful to have non-100% translation coverage. I just copied them verbatim, I didn't actually translate them. Without translating them I can't tell if I've translated everything when doing a "msgfmt -vvv --check sv.po". -- \\// Peter - http://www.softwolves.pp.se/