From: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Date: Wed, 05 Jan 2011 02:25:46 GMT
Subject: Re: [PATCH 08/31] rebase: align variable names
Message-ID: <alpine.DEB.1.10.1101042112190.6201@debian>
In-Reply-To: <201101042012.25580.trast@student.ethz.ch>

On Tue, 4 Jan 2011, Thomas Rast wrote:

> Martin von Zweigbergk wrote:
> > Use the same names for variables that git-rebase--interactive.sh will
> > soon inherit from git-rebase.sh.
> 
> AFAICS this is partly about spelling the variables in lowercase
> instead of all-caps.
> 
> Wouldn't it be nicer to simply downcase *all* variables, so that the
> end result has a consistent coding style?

Yes, it would :-). I was just being conservative by trying not to
touch code that I didn't have to touch. I'll rename the remaining
variables in the next iteration.

Thanks,
Martin