From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 11 Sep 2014 14:22:10 GMT
Subject: Re: [PATCH v2 6/6] Make sure that index-pack --strict fails upon invalid tag objects
Message-ID: <alpine.DEB.1.00.1409111620420.990@s15462909.onlinehome-server.info>
In-Reply-To: <xmqqoaunf8fv.fsf@gitster.dls.corp.google.com>

Hi,

On Wed, 10 Sep 2014, Junio C Hamano wrote:

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > +    tag=$(git hash-object -t tag -w --stdin <wrong-tag) &&
> > +    pack1=$(echo $tag | git pack-objects tag-test) &&
> > +    echo remove tag object &&
> > +    thirtyeight=${tag#??} &&
> > +    rm -f .git/objects/${tag%$thirtyeight}/$thirtyeight &&
> > +    test_must_fail git index-pack --strict tag-test-${pack1}.pack 2> err &&
> 
> I had to drop "must fail" from this one (will amend the "SQUASH???"
> again).

Funny. It failed here, but for the wrong reason: index-pack --strict
failed here because the object referenced by the tag object was not in the
pack.

Ciao,
Dscho