From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 11 Sep 2014 14:15:46 GMT
Subject: Re: [PATCH v2 5/6] Add regression tests for stricter tag fsck'ing
Message-ID: <alpine.DEB.1.00.1409111614420.990@s15462909.onlinehome-server.info>
In-Reply-To: <xmqqbnqngy0z.fsf@gitster.dls.corp.google.com>

Hi Junio,

On Wed, 10 Sep 2014, Junio C Hamano wrote:

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > +	test_when_finished "git update-ref -d refs/tags/wrong" &&
> > +	git fsck --tags 2>out &&
> 
> I wonder what the command does with or without --tags option
> (applies to both tests added by this patch)?
> 
> Does running "fsck" without the option not to report broken tags
> detected by the new checks added in this series?  Should it?

fsck fails perfectly fine without the --tags option; this option just
triggers that fsck will show also the objects referenced by the tag
objects (which is nice for debugging).

Ciao,
Dscho