From: Johannes Schindelin Date: Thu, 15 May 2014 17:44:08 GMT Subject: Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option Message-ID: In-Reply-To: Hi Junio, On Wed, 14 May 2014, Junio C Hamano wrote: > Jonathan Nieder writes: > > >>> + if (opt.ignore_case && !strcmp("less", pager)) > >>> + string_list_append(&path_list, "-i"); > >> > >> I have a feeling that this goes against the recent trend of not > >> mucking with the expectation of the users on their pagers, if I > >> recall correctly the arguments for dropping S from the default given > >> to an unconfigured LESS environment variable. > > > > It's just missing an explanation. > > ... > > (That's -I, not -i, because it ought to work even when the pattern > > contains capital letters.) > > Spot on. The change, especially with "-I", makes sense. Except that it was not tested with -I. If you change it that way and it stops working on Windows, it's useless to me. Ciao, Johannes -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.