From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 08 Aug 2013 21:36:28 GMT
Subject: Re: [PATCH] diff: remove another ternary expression always evaluating to true
Message-ID: <alpine.DEB.1.00.1308082335050.24252@s15462909.onlinehome-server.info>
In-Reply-To: <52040C18.4030306@googlemail.com>

Hi Stefan,

On Thu, 8 Aug 2013, Stefan Beller wrote:

> So you rather propose to have 
> -		show_submodule_summary(o->file, one ? one->path : two->path,
> +		show_submodule_summary(o->file, one->path ? one->path : two->path,

I do. The reason is that one->path could be NULL (but not both one->path
and two->path) and the summary would not be as helpful as possible if it
wrote "(null)" instead of the path of the submodule.

Ciao,
Johannes