From: Johannes Schindelin Date: Thu, 14 Mar 2013 16:57:43 GMT Subject: Re: Re: [PATCH/RFC] http_init: only initialize SSL for https Message-ID: In-Reply-To: <7vy5dqx913.fsf@alter.siamese.dyndns.org> Hi Junio, On Thu, 14 Mar 2013, Junio C Hamano wrote: > Erik Faye-Lund writes: > > > diff --git a/http.c b/http.c > > index 3b312a8..528a736 100644 > > --- a/http.c > > +++ b/http.c > > @@ -343,7 +343,8 @@ void http_init(struct remote *remote, const char *url, int proactive_auth) > > > > git_config(http_options, NULL); > > > > - curl_global_init(CURL_GLOBAL_ALL); > > + curl_global_init(CURL_GLOBAL_WIN32 | (prefixcmp(url, "https:") ? 0 : > > + CURL_GLOBAL_SSL)); > > The first and obvious question is what the symbol with a name > specific to one single platform doing in this generic codepath. > In order to get convinced that the patch does not regress, one > somehow need to know that bits in ALL other than WIN32 and SSL > do not matter (or there is no such bit). > > I'd understand if it were "ALL & ~SSL" though. Hence my earlier suggestion (with the obvious tyop '^' instead of '~'). You will also find the information in my mail (unless you plonk my mails) that CURL_GLOBAL_ALL is defined as CURL_GLOBAL_WIN32 | CURL_GLOBAL_SSL, and in kusma's response the suggestion to use DEFAULT & ~SSL instead. Ciao, Johannes -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.