From: Johannes Schindelin Date: Mon, 25 Feb 2013 19:01:21 GMT Subject: Re: [PATCH 0/5] Fix msvc build Message-ID: In-Reply-To: <512B2003.804@viscovery.net> Hi Hannes, On Mon, 25 Feb 2013, Johannes Sixt wrote: > Am 2/25/2013 7:54, schrieb Junio C Hamano: > > Ramsay Jones writes: > > > >> As I mentioned recently, while discussing a cygwin specific patch > >> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the > >> MSVC build is broken for me. > >> > >> The first 4 patches fix the MSVC build for me. The final patch is > >> not really related to fixing the build, but it removed some make > >> warnings which were quite irritating ... > >> > >> Note that I used the Makefile, with the Visual C++ 2008 command > >> line compiler on Windows XP (SP3), to build a vanilla git on MinGW. > >> I'm not subscribed to the msysgit mailing list, nor do I follow the > >> msysgit fork of git, so these patches may conflict with commits in > >> their repository. > > > > Did anything further happen to this topic in the Windows land? > > I successfully built with MSVC with these patches (but I am not using the > result anywhere nor did I attempt to run the test suite). > > More importantly, I'm using git on Windows ("MinGW flavor") with these > patches in production, so there are no obvious regressions. > > Feel free to add my > > Tested-by: Johannes Sixt > > but if you don't have the patches around, I can resend them. Can you please send a pull request on GitHub? Thanks, Johannes -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.