From: Johannes Schindelin Date: Tue, 13 Nov 2012 04:52:48 GMT Subject: Re: Re: [PATCH] git tag --contains : avoid stack overflow Message-ID: In-Reply-To: <20121113040541.GA9439@sigill.intra.peff.net> Hi Peff, On Mon, 12 Nov 2012, Jeff King wrote: > On Tue, Nov 13, 2012 at 04:01:11AM +0000, Johannes Schindelin wrote: > > > > Note that name-rev will produce wrong answers in the face of clock skew. > > > And I think that you even wrote that code. :) > > > > IIRC the cute code to short-circuit using the date is not from me. If it > > is, I am very ashamed. > > Sorry, but it was: > > $ git blame -L'/commit->date < cutoff/',+1 builtin/name-rev.c > bd321bcc name-rev.c (Johannes Schindelin 2005-10-26 15:10:20 +0200 32) > if (commit->date < cutoff) > > But it is never too late to fix it. :) I will now go and find a hole to hide in. Or alternatively finally go to sleep. Ciao, Johannes -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en