From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 23 Feb 2010 12:57:59 GMT
Subject: Re: [PATCH] Print RUNTIME_PREFIX warning only when GIT_TRACE is set
Message-ID: <alpine.DEB.1.00.1002231357460.3980@intel-tinevez-2-302>
In-Reply-To: <4B83BF40.4070802@viscovery.net>

Hi,

On Tue, 23 Feb 2010, Johannes Sixt wrote:

> From: Johannes Sixt <j6t@kdbg.org>
> 
> When RUNTIME_PREFIX is enabled, the installation prefix is derived by
> trying a limited set of known locations where the git executable can
> reside. If none of these is found, a warning is emitted.
> 
> When git is built in a directory that matches neither of these known names,
> the warning would always be emitted when the uninstalled executable is run.
> This is a problem on Windows, where gitk picks the uninstalled git when
> invoked from the build directory and gets confused by the warning.
> 
> Print the warning only when GIT_TRACE is set.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>

ACK

And thanks,
Dscho