From: Johannes Schindelin Date: Sat, 30 Jan 2010 10:50:04 GMT Subject: Re: [PATCH] Implement pthread_cond_broadcast on Windows Message-ID: In-Reply-To: <201001301030.36395.j6t@kdbg.org> Hi, On Sat, 30 Jan 2010, Johannes Sixt wrote: > On Samstag, 30. Januar 2010, Johannes Schindelin wrote: > > > On Sat, 30 Jan 2010, Johannes Sixt wrote: > > > See http://www.cse.wustl.edu/~schmidt/win32-cv-1.html, section "The > > > SignalObjectAndWait solution". But note that this implementation > > > does not use SignalObjectAndWait (which is needed to achieve > > > fairness, but we do not need fairness). > > > > > > Note that our implementations of pthread_cond_broadcast and > > > pthread_cond_signal require that they are invoked with the mutex > > > held that is used in the pthread_cond_wait calls. > > > > > > Signed-off-by: Johannes Sixt > > > --- > > > Junio, > > > > > > please queue this patch for 1.7.0-rc1 even though it has not > > > undergone a lot of review - the result is better than a git that > > > does not even build on Windows. > > > > As you Cc:ed the msysGit list, do you want this in 4msysgit.git, too? > > I hope some clever people on the msysgit list can say aye or nay to this > patch. If you intend to release an msysgit that contains 5b594f4 > (Threaded grep), then you need *something*, otherwise the build fails. > Whether you get that something via upstream or apply it directly is of > course secondary, but I prefer the former. ;) Okay, I will just merge mingw.git's master, then, once you say that the fix is in. Ciao, Dscho