From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 27 Oct 2009 14:17:28 GMT
Subject: Re: [PATCH] rebase -i: more graceful handling of invalid commands
Message-ID: <alpine.DEB.1.00.0910271517180.11562@felix-maschine>
In-Reply-To: <20091027133932.60b996c3@perceptron>

Hi,

On Tue, 27 Oct 2009, Jan Krüger wrote:

> Currently, when there is an invalid command, the rest of the line is
> still treated as if the command had been valid, i.e. rebase -i attempts
> to produce a patch, using the next argument as a SHA1 name. If there is
> no next argument or an invalid one, very confusing error messages
> appear (the line was '.'; path to git-rebase-todo substituted):
> 
> Unknown command: .
> fatal: ambiguous argument 'Please fix this in the file $somefile.':
> unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions
> fatal: Not a valid object name Please fix this in the file $somefile.
> fatal: bad revision 'Please fix this in the file $somefile.'
> 
> Instead, verify the validity of the remaining line and error out earlier
> if necessary.
> 
> Signed-off-by: Jan Krüger <jk@jk.gs>

ACK,
Dscho