From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 16 Oct 2009 11:30:18 GMT
Subject: Re: [PATCH 2/3] strbuf_nested_expand(): allow expansion to interrupt in the middle
Message-ID: <alpine.DEB.1.00.0910161329270.4985@pacific.mpi-cbg.de>
In-Reply-To: <1255681702-5215-3-git-send-email-gitster@pobox.com>

Hi,

On Fri, 16 Oct 2009, Junio C Hamano wrote:

>  		consumed = fn(sb, format, context);
> -		if (consumed)
> +		if ((ssize_t) consumed < 0)
> +			break;

Would it not be much better to fix the signature of fn in a separate 
commit before this one?

Ciao,
Dscho