From: Johannes Schindelin Date: Tue, 18 Aug 2009 09:34:06 GMT Subject: Re: [msysGit] Re: [PATCH 02/11] Fix declare variable at mid of function Message-ID: In-Reply-To: <4A8A3ADE.9010703@gmail.com> Hi, On Tue, 18 Aug 2009, Marius Storm-Olsen wrote: > Johannes Schindelin said the following on 17.08.2009 21:36: > > > On Mon, 17 Aug 2009, Reece Dunn wrote: > > > > > 2009/8/17 Johannes Schindelin : > > > > > > > On Tue, 18 Aug 2009, Frank Li wrote: > > > > > > > > > Some compiler such as MSVC can't support declear variable at mid of > > > > > funtion at c file. > > > > Please wrap your commit messages after 76 characters. > > > > > > > > > Signed-off-by: Frank Li > > > > > --- > > > > How about this instead? > > > > > > > > Avoid declaration after instruction > > > > > > > > Microsoft Visual C++ does not understand this C99 style. > > > > > > > > ? > > > > > > > > The patch itself is good. > > > Shouldn't GCC be changed to use -std=c89 as well to pick up errors for > > > compilers that don't support c99 (like the Microsoft Visual C++ C > > > compiler)? > > > > Hmm. I played with the thought of adding -Werror -Wno-pointer-to-int-cast > > -Wold-style-definition -Wdeclaration-after-statement like Junio described in > > one of his mails for MinGW (as we _know_ what compiler we have there). > > > > Dunno. > > IMO it would be a good change. We should not have any of those anyways.. Okay, I will wait for Frank's updates (just fetched tgit.git and it still contains the old branch), merge the early part and add the compiler flags. Ciao, Dscho