From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 18 Aug 2009 00:24:02 GMT
Subject: Re: [PATCH] block-sha1: make the size member first in the context struct
Message-ID: <alpine.DEB.1.00.0908180223280.8306@pacific.mpi-cbg.de>
In-Reply-To: <alpine.LFD.2.00.0908172012591.6044@xanadu.home>

Hi,

On Mon, 17 Aug 2009, Nicolas Pitre wrote:

> This is a 64-bit value, hence having it first provides a better 
> alignment.
> 
> Signed-off-by: Nicolas Pitre <nico@cam.org>
> 
> diff --git a/block-sha1/sha1.h b/block-sha1/sha1.h
> index 6ff59b2..b864df6 100644
> --- a/block-sha1/sha1.h
> +++ b/block-sha1/sha1.h
> @@ -7,9 +7,9 @@
>   */
>  
>  typedef struct {
> +	unsigned long long size;
>  	unsigned int H[5];
>  	unsigned int W[16];
> -	unsigned long long size;
>  } blk_SHA_CTX;

By the reasoning suggested in the commit message, should H[5] not go to 
the end?

Ciao,
Dscho