From: Johannes Schindelin Date: Mon, 17 Aug 2009 21:00:55 GMT Subject: Re: [msysGit] Re: [PATCH 02/11] Fix declare variable at mid of function Message-ID: In-Reply-To: <7v1vnauto6.fsf@alter.siamese.dyndns.org> Hi, On Mon, 17 Aug 2009, Junio C Hamano wrote: > Johannes Schindelin writes: > > > How about this instead? > > > > Avoid declaration after instruction > > It's called declaration-after-statement. Of course. Thank you. > I always compile with "-Wall -Wdeclaration-after-statement -Werror" > (among other things; if you are interested, see "Make" script in 'todo' > branch for details) but this being in compat/mingw.c, obviously it is > outside of my coverage. I have this in my own tree since long ago, back when you sent a mail whose reference I did not record, unfortunately. Of course, msysGit was not there yet to allow me to compile my tree (and more importantly, pass the test suite), so I did not realize the violations in compat/. Hence my intention to set the compiler flags just after merging the early commits of Frank's work. Ciao, Dscho