From: Johannes Schindelin Date: Mon, 17 Aug 2009 19:46:14 GMT Subject: Re: [PATCH 05/11] Remove va_copy at MSVC because there are va_copy. Message-ID: In-Reply-To: <40aa078e0908171002j4b610fe4j34a4e7d3081a9efa@mail.gmail.com> Hi, On Mon, 17 Aug 2009, Erik Faye-Lund wrote: > On Mon, Aug 17, 2009 at 6:53 PM, Paolo Bonzini wrote: > > #ifndef va_copy > > #define va_copy(dst, src)       ((dst) = (src)) > > #endif > > Are you sure va_copy is always a preprocessor symbol? How about > > #ifdef _MSC_VER > #define va_copy(dst, src) ((dst) = (src)) > #endif Why not #define it in compat/msvc.h? Or introduce a DEFINE_VA_COPY_TRIVIALLY symbol or some such? Ciao, Dscho