From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 17 Aug 2009 17:16:10 GMT
Subject: Re: [PATCH 11/11] Add gitignore and ReadMe file for MSVC Build
Message-ID: <alpine.DEB.1.00.0908171915130.4991@intel-tinevez-2-302>
In-Reply-To: <1250525340-412-1-git-send-email-lznuaa@gmail.com>

Hi,

On Tue, 18 Aug 2009, Frank Li wrote:

> Add ReadMe to user how to build git with MSVC.
> Add gitignore to filter out files created file by MSVC.
> 
> Signed-off-by: Frank Li <lznuaa@gmail.com>

Please use the plural form "files" where appropriate.

> diff --git a/compat/vcbuild/ReadMe b/compat/vcbuild/ReadMe
> new file mode 100644
> index 0000000..47c089e
> --- /dev/null
> +++ b/compat/vcbuild/ReadMe
> @@ -0,0 +1,13 @@
> +The Steps of Build Git with VS2008
> +
> +1. Create VC Build Environment.
> +
> +   git clone git://repo.or.cz/gitbuild.git
> +
> +   gitbuild include VS solution file and library such as zlib.

How, if you do not have Git?

> +2. Get Submodule
> +  
> +   git submodule update

This is missing '--init'.

Ciao,
Dscho