From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 13 Aug 2009 10:19:28 GMT
Subject: Re: [PATCH 1/4] fast-import: put option parsing code in seperate functions
Message-ID: <alpine.DEB.1.00.0908131208400.7429@intel-tinevez-2-302>
In-Reply-To: <1250140186-12363-2-git-send-email-srabbelier@gmail.com>

Hi,

On Wed, 12 Aug 2009, Sverre Rabbelier wrote:

> +static void option_export_marks(const char *marks)
> +{
> +	struct strbuf buf = STRBUF_INIT;
> +	strbuf_addstr(&buf, marks);
> +	mark_file = strbuf_detach(&buf, NULL);
> +}

Heh, this is a pretty convoluted way to write

	mark_file = xstrdup(marks);

;-)

> +static void option_force()
> +{
> +	force_update = 1;
> +}

I'm not sure that I would put these simple assignments in separate 
functions, but that's certainly up to you!

Thanks,
Dscho