From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 29 Jul 2009 16:40:41 GMT
Subject: Re: [PATCHv3 1/8] Introduce commit notes
Message-ID: <alpine.DEB.1.00.0907291839350.7626@intel-tinevez-2-302>
In-Reply-To: <81b0412b0907290152w27c1b5b5l9efbd6980d4f904e@mail.gmail.com>

Hi,

On Wed, 29 Jul 2009, Alex Riesen wrote:

> On Wed, Jul 29, 2009 at 04:25, Johan Herland<johan@herland.net> wrote:
> > +void get_commit_notes(const struct commit *commit, struct strbuf *sb,
> > +               const char *output_encoding)
> > +{
> > +       static const char *utf8 = "utf-8";
> 
> Using an array
> 
>   const char utf8[] = "utf-8";
> 
> costs you less BSS (no separate storage for the pointer).

Good to know!

> > @@ -963,5 +964,9 @@ void pretty_print_commit(enum cmit_fmt fmt, const struct commit *commit,
> > +
> > +       if (fmt != CMIT_FMT_ONELINE)
> > +               get_commit_notes(commit, sb, encoding);
> > +
> 
> Someday we will need a way to switch off the display of notes
> without resolving to oneline format.
> Is there a notes specifier for the printf-like log message formatting
> (--pretty=format: or --format) planned, BTW?

That would probably be something like "GIT_NOTES_REF=nyanyanya git log"?

Ciao,
Dscho