From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 30 Jun 2009 14:20:51 GMT
Subject: Re: [PATCH] git-mv: fix directory separator treatment on Windows
Message-ID: <alpine.DEB.1.00.0906301620370.4773@pacific.mpi-cbg.de>
In-Reply-To: <4A4A1445.6090704@viscovery.net>

Hi,

On Tue, 30 Jun 2009, Johannes Sixt wrote:

> From: Johannes Sixt <j6t@kdbg.org>
> 
> The following invocations did not work as expected on Windows:
> 
>     git mv foo\bar dest
>     git mv foo\ dest
> 
> The first command was interpreted as
> 
>     git mv foo/bar dest/foo/bar
> 
> because the Windows style directory separator was not obeyed when the
> basename of 'foo\bar' was computed.
> 
> The second command failed because the Windows style directory separator was
> not removed from the source directory, whereupon the lookup of the
> directory in the index failed.
> 
> This fixes both issues by using is_dir_sep() and basename().
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>

ACK

Dscho