From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 01 Jun 2009 09:00:33 GMT
Subject: Re: [PATCH 04/11] test-chmtime: work around Windows limitation
Message-ID: <alpine.DEB.1.00.0906011058120.26154@pacific.mpi-cbg.de>
In-Reply-To: <7vab4smmab.fsf@alter.siamese.dyndns.org>

Hi,

On Mon, 1 Jun 2009, Junio C Hamano wrote:

> Steffen Prohaska <prohaska@zib.de> writes:
> 
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > Windows has problems changing the mtime when the file is write protected,
> > even by the owner of said file.
> >
> > Add a Windows-only workaround to change the mode if necessary before
> > trying to change the mtime.
> 
> I'll queue this as-is for now, but shouldn't the code remember the
> original mode and change it back?

Hmm, good point.  As I mentioned in another mail, though, I cannot access 
any Windows machine to fix this issue now, sorry.

Not changing the mode back _might_ paper over another issue: if the files 
are deleted later, that mode change might mean that the deletion now 
succeeds, and fixing test-chmtime may make it fail again.  Not sure, 
though.

Ciao,
Dscho