From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 29 Apr 2009 22:44:25 GMT
Subject: Re: [PATCH] git config: error when editing a repo config and not being in one
Message-ID: <alpine.DEB.1.00.0904300043030.10279@pacific.mpi-cbg.de>
In-Reply-To: <1241043939-29013-1-git-send-email-felipe.contreras@gmail.com>

Hi,

On Thu, 30 Apr 2009, Felipe Contreras wrote:

> diff --git a/builtin-config.c b/builtin-config.c
> index d8da72c..6e936e1 100644
> --- a/builtin-config.c
> +++ b/builtin-config.c
> @@ -390,6 +390,8 @@ int cmd_config(int argc, const char **argv, const char *unused_prefix)
>  	}
>  	else if (actions == ACTION_EDIT) {
>  		check_argc(argc, 0, 0);
> +		if (!config_exclusive_filename && !is_inside_git_dir())
> +			die("not in a git directory");

Why not use the nongit variable?

Ciao,
Dscho