From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 18 Apr 2009 21:15:05 GMT
Subject: Re: [PATCH] Add the diff option --no-defaults
Message-ID: <alpine.DEB.1.00.0904182311330.10279@pacific.mpi-cbg.de>
In-Reply-To: <alpine.GSO.2.00.0904181308440.16775@kiwi.cs.ucla.edu>

Hi.

On Sat, 18 Apr 2009, Keith Cascio wrote:

> On Sat, 18 Apr 2009, Johannes Schindelin wrote:
> 
> > And I still do not like the intrusiveness of your patch.  The last 
> > time we did something like that with options (some 
> > parseoptifications), we had a lot of fallout as a consequence.
> 
> [...]
>
> Peff expressed some specific concerns [...]

My concerns were also very specific: your patches are way too large.  
There is a rule of thumb that the likelihood of a bug is the square of the 
number of changed lines, I am sure you heard that before.

> [...] your patch adds at least ten lines outside of diff.h/diff.c.

That is _such_ a red herring.

Ciao,
Dscho