From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 08 Mar 2009 01:19:29 GMT
Subject: Re: [PATCH/RFD] builtin-revert.c: release index lock when cherry-picking an empty commit
Message-ID: <alpine.DEB.1.00.0903080218070.10279@pacific.mpi-cbg.de>
In-Reply-To: <EEE56CB5-BBC7-45F4-801B-062349E07730@pobox.com>

Hi,

On Sat, 7 Mar 2009, Chris Johnsen wrote:

> On 2009 Mar 7, Johannes Schindelin wrote:
> >I wonder, though, if the real root of the problem is that there is
> >copied code.
> 
> Agreed.
> 
> >IOW I think it would be better to introduce a global
> >function that writes the index to a tree.
> 
> I am not quite sure I follow your meaning here.

Well, my thinking was that instead of imitating what merge-recursive does, 
you could refactor that very code into a function that gets called from 
both merge-recursive and revert.

Ciao,
Dscho