From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 17 Feb 2009 12:05:26 GMT
Subject: Re: [PATCH] Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-masking
Message-ID: <alpine.DEB.1.00.0902171304130.6185@intel-tinevez-2-302>
In-Reply-To: <1234841209-3960-1-git-send-email-keith@cs.ucla.edu>

Hi,

On Mon, 16 Feb 2009, Keith Cascio wrote:

> 
> Signed-off-by: Keith Cascio <keith@cs.ucla.edu>
> ---

Rationale?

If you are going to add something on top of that, I can understand that, 
but this patch is not labeled [1/n].  And...

>  diff.h |    3 +++
>  diff.c |   17 ++++++++++-------
>  2 files changed, 13 insertions(+), 7 deletions(-)

... this does not look good to me, without a compelling reason why we want 
to have the patch nevertheless.

Ciao,
Dscho