From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 15 Feb 2009 19:41:02 GMT
Subject: Re: [PATCH v2] config: Use parseopt.
Message-ID: <alpine.DEB.1.00.0902152040350.10279@pacific.mpi-cbg.de>
In-Reply-To: <7v1vtzmr9j.fsf@gitster.siamese.dyndns.org>

Hi,

On Sun, 15 Feb 2009, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> > Or maybe even better: set a variable "ret" and at the end of 
> >> > cmd_config(), "return !!ret;"?
> >> 
> >> Huh? So git commands don't return negative error values?
> >
> > AFAICT an exit status is supposed to be between 0 and 127.
> 
> Are you two talking about the return value from cmd_config()?
> 
> git.c::run_builtin() already knows what to do with status codes from the
> builtins to protect you from (rare) shells that do not cope with a
> negative return that come from the common pattern of doing:
> 
> 	return error("it is wrong in this way")
> 
> So "negative" is not really a problem.

Ooops.  I missed that.

Ciao,
Dscho