From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 15 Feb 2009 16:46:59 GMT
Subject: Re: [PATCH] Make repack less likely to corrupt repository
Message-ID: <alpine.DEB.1.00.0902151745270.10279@pacific.mpi-cbg.de>
In-Reply-To: <200902151715.19351.robin.rosenberg.lists@dewire.com>

Hi,

On Sun, 15 Feb 2009, Robin Rosenberg wrote:
> -	exit 1
> +	echo >&2 "INFO: We recovered from the repack error, but your repo"
> +	echo >&2 "INFO: is probably suboptimally packed. You may try to repack"
> +	echo >&2 "INFO: later. A common reason for repacking failure is that"
> +	echo >&2 "INFO: a Windows program was locking one of the old pack files."
> +	echo >&2 "INFO: To repack successfully you may have to close that program"
> +	echo >&2 "INFO: before repacking."

cat >&2 << EOF?

> +	exit

You lose the error condition here, but I cannot find a convincing argument 
about that in the commit message.

Ciao,
Dscho