From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 14 Feb 2009 19:33:44 GMT
Subject: Re: [PATCH 4/4] notes: refuse to edit notes outside refs/notes/
Message-ID: <alpine.DEB.1.00.0902142032210.10279@pacific.mpi-cbg.de>
In-Reply-To: <ac3c2ce272e8e7f3000349f682a5a4843aea34e6.1234638466.git.trast@student.ethz.ch>

Hi,

On Sat, 14 Feb 2009, Thomas Rast wrote:

> The current git-notes has no safety valves whatsoever, and will
> happily edit notes in, e.g., refs/remotes/.  This is dangerous, as
> they will be overwritten during the next fetch of the remote they
> belong to.
> 
> Since it is supposed to be a plumbing frontend for the notes feature,
> simply forbid editing notes with GIT_NOTES_REF pointing anywhere but
> refs/notes/*.

ACK.

Except maybe for calling it "plumbing".  "git notes" is meant to be _the_ 
porcelain of the "notes", and that is why I like the idea to restrict it 
to refs/notes/* for editing (not for anything else, though).

Thanks,
Dscho