From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 07 Feb 2009 21:14:58 GMT
Subject: Re: [PATCH v3] config: Add new option to open an editor.
Message-ID: <alpine.DEB.1.00.0902072214410.10279@pacific.mpi-cbg.de>
In-Reply-To: <94a0d4530902071309l7c34945ana2af31e41707fa0c@mail.gmail.com>

Hi,

On Sat, 7 Feb 2009, Felipe Contreras wrote:

> On Thu, Feb 5, 2009 at 1:49 AM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > Hi,
> >
> > On Thu, 5 Feb 2009, Johannes Schindelin wrote:
> >
> >> On Wed, 4 Feb 2009, Junio C Hamano wrote:
> >>
> >> > Felipe Contreras <felipe.contreras@gmail.com> writes:
> >> >
> >> > > The idea was originated by discussion about usability of manually
> >> > > editing the config file in 'special needs' systems such as Windows. Now
> >> > > the user can forget a bit about where the config files actually are.
> >> >
> >> > Does this honor core.editor setting in existing configuration files?
> >>
> >> It should, as it uses launch_editor().
> >
> > Oh, I see that launch_editor() does not do its own git_config() parsing.
> > Dunno if it should...
> 
> I think it should, how expensive would it be to call
> git_config(git_default_config, NULL) when it has been loaded already?

We would not need the complete git_default_config(), would we?

Ciao,
Dscho