From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 06 Feb 2009 15:36:14 GMT
Subject: Re: [PATCH 1/2] git notes show: test empty notes
Message-ID: <alpine.DEB.1.00.0902061635560.7377@intel-tinevez-2-302>
In-Reply-To: <1233933543-28407-2-git-send-email-git@drmicha.warpmail.net>

Hi,

On Fri, 6 Feb 2009, Michael J Gruber wrote:

> Add a test for the handling of empty notes by "git notes show".
> ---
>  t/t3301-notes.sh |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
> index 9393a25..4900dca 100755
> --- a/t/t3301-notes.sh
> +++ b/t/t3301-notes.sh
> @@ -35,6 +35,11 @@ test_expect_success 'need valid notes ref' '
>  	! MSG=2 GIT_NOTES_REF='/' git notes show
>  '
>  
> +# 1 indicates caught gracefully by die, 128 means git-show barfed
> +test_expect_failure 'handle empty notes gracefully' '
> +	git notes show || test 1 = $?
> +'

That test would succeed if the exit status is 0.

Ciao,
Dscho