From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 06 Feb 2009 13:03:39 GMT
Subject: Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match
Message-ID: <alpine.DEB.1.00.0902061403130.7377@intel-tinevez-2-302>
In-Reply-To: <200902061149.16210.jnareb@gmail.com>

Hi,

On Fri, 6 Feb 2009, Jakub Narebski wrote:

> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index f27dbb6..5dcc108 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1364,7 +1364,7 @@ sub format_log_line_html {
>  	my $line = shift;
>  
>  	$line = esc_html($line, -nbsp=>1);
> -	if ($line =~ m/([0-9a-fA-F]{8,40})/) {
> +	if ($line =~ m/\b([0-9a-fA-F]{8,40})\b(!?\@)/) {

Looks good to me!

Thanks,
Dscho