From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 05 Feb 2009 20:51:23 GMT
Subject: Re: [PATCH] valgrind: do not require valgrind 3.4.0 or newer
Message-ID: <alpine.DEB.1.00.0902052150230.7491@intel-tinevez-2-302>
In-Reply-To: <7vzlh0bp6f.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 5 Feb 2009, Junio C Hamano wrote:

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > Valgrind 3.4.0 is pretty new, and even if --track-origins is a nice
> > feature, it is not the end of the world if that is not available.  So
> > play nice and use that option only when only an older version of
> > valgrind is available.
> 
> s/older/newer/?

s/only an older/a newer/  even.

> > +TRACK_ORIGINS=
> > +case "$(valgrind --version)" in
> > +valgrind-{3.[4-9],3.[1-3][0-9],[4-9],[1-3][0-9]}*)
> > +	TRACK_ORIGINS=--track-origins=yes
> > +esac
> 
> What kind of case pattern is that?

A non-working one.

Grumbles,
Dscho