From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 01 Feb 2009 22:24:13 GMT
Subject: Re: [PATCH 1/2] t3412: clean up GIT_EDITOR usage
Message-ID: <alpine.DEB.1.00.0902012322490.3586@pacific.mpi-cbg.de>
In-Reply-To: <1233355621-4783-1-git-send-email-trast@student.ethz.ch>

Hi,

On Fri, 30 Jan 2009, Thomas Rast wrote:

> a6c7a27 (rebase -i: correctly remember --root flag across --continue,
> 2009-01-26) introduced a more portable GIT_EDITOR usage, but left the
> old tests unchanged.
> 
> Since we never use the editor (all tests run the rebase script as
> proposed by rebase -i), just disable it outright, which simplifies the
> tests.
> 
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>  t/t3412-rebase-root.sh |   38 +++++++++++++-------------------------
>  1 files changed, 13 insertions(+), 25 deletions(-)
> 
> diff --git a/t/t3412-rebase-root.sh b/t/t3412-rebase-root.sh
> index 9fc528f..8a9154a 100755
> --- a/t/t3412-rebase-root.sh
> +++ b/t/t3412-rebase-root.sh
> @@ -6,6 +6,10 @@ Tests if git rebase --root --onto <newparent> can rebase the root commit.
>  '
>  . ./test-lib.sh
>  
> +# we always run the interactive rebases unchanged, so just disable the editor
> +GIT_EDITOR=:
> +export GIT_EDITOR
> +

According to my analysis, this is unneeded.  Just leave GIT_EDITOR alone 
in the whole test.

Ciao,
Dscho