From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 30 Jan 2009 00:28:38 GMT
Subject: Re: [PATCH] push: Learn to set up branch tracking with '--track'
Message-ID: <alpine.DEB.1.00.0901300127450.3586@pacific.mpi-cbg.de>
In-Reply-To: <20090129231715.GA17399@coredump.intra.peff.net>

Hi,

On Thu, 29 Jan 2009, Jeff King wrote:

> On Thu, Jan 29, 2009 at 05:33:08PM -0500, Jeff King wrote:
> 
> > So I think this patch is going about it the wrong way. Instead of
> > parsing the refspec, I think you actually want to look at what we _do_
> > push (or at least try to push -- probably even uptodate refs should also
> > have tracking established), and use that. Then you will have wildcards
> > expanded, --all handled, etc. And I suspect all you have to do is
> > iterate over the result of match_refs (which we call later), which
> > should be even easier (because you don't have to parse the refspecs
> > yourself). But I haven't looked carefully.
> 
> Something like the patch below (which is obviously missing all of the 
> infrastructure for doing this optionally, but is meant to illustrate 
> what I'm talking about).

Except that you miss http:// and rsync:// protocols.  Those were the 
reasons I did not touch send-pack.

Ciao,
Dscho