From: Johannes Schindelin Date: Wed, 28 Jan 2009 23:06:19 GMT Subject: Re: [PATCH] http-push: refactor request url creation Message-ID: In-Reply-To: <7vvdrzjb80.fsf@gitster.siamese.dyndns.org> Hi, On Wed, 28 Jan 2009, Junio C Hamano wrote: > I thought at least you did not have these overlong lines in your earlier > attempts, and Dscho may have acked one of those, but I doubt he would > give his Ack to this one. I certainly wouldn't Ack it myself. My understanding is that the ACK is sent to the mailing list by the Acker and in response to the particular patch she is Acking. > The refactoring looked sane otherwise, but I think we would want to opt > for safety by keeping an extra string around. Yep. Better safe 'n sorry. Ciao, Dscho