From: Johannes Schindelin Date: Tue, 27 Jan 2009 23:07:36 GMT Subject: [PATCH 1/2] test-path-utils: Fix off by one, found by valgrind Message-ID: In-Reply-To: When normalizing an absolute path, we might have to add a slash _and_ a NUL to the buffer, so the buffer was one too small. Let's just future proof the code and alloc PATH_MAX + 1 bytes. Signed-off-by: Johannes Schindelin --- test-path-utils.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test-path-utils.c b/test-path-utils.c index a0bcb0e..2c0f5a3 100644 --- a/test-path-utils.c +++ b/test-path-utils.c @@ -3,7 +3,7 @@ int main(int argc, char **argv) { if (argc == 3 && !strcmp(argv[1], "normalize_absolute_path")) { - char *buf = xmalloc(strlen(argv[2])+1); + char *buf = xmalloc(PATH_MAX + 1); int rv = normalize_absolute_path(buf, argv[2]); assert(strlen(buf) == rv); puts(buf); -- 1.6.1.482.g7d54be