From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 26 Jan 2009 20:38:03 GMT
Subject: Re: [PATCH 2/3] Make has_commit non-static
Message-ID: <alpine.DEB.1.00.0901262137290.25749@intel-tinevez-2-302>
In-Reply-To: <7v63k16dd0.fsf@gitster.siamese.dyndns.org>

Hi,

On Mon, 26 Jan 2009, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Mon, 26 Jan 2009, Jake Goulding wrote:
> >
> >> Moving has_commit from branch to a common location in preparation for 
> >> using it in tag. Renaming it to commit_has_any_in_commit_list to be 
> >> more unique.
> >
> > I feel like bike-shedding for a change, and I'd also like to prove 
> > that not all Germans like long names:
> >
> > 	is_ancestor_of_any()
> >
> > Hmm?
> 
> Is it ancestor or descendant?  The latter makes the name longer, though 
> ;-)

I did not read the patch and missed that it means the opposite, sorry...

Ciao,
Dscho