From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 25 Jan 2009 01:59:53 GMT
Subject: Re: [PATCH 08/10] run test suite without dashed git-commands in PATH
Message-ID: <alpine.DEB.1.00.0901250255250.14855@racer>
In-Reply-To: <1232840601-24696-9-git-send-email-mmogilvi_git@miniinfo.net>

Hi,

On Sat, 24 Jan 2009, Matthew Ogilvie wrote:

>  .gitignore          |    1 +
>  Makefile            |   42 +++++++++++++++++++++++++++++++-----------
>  t/test-lib.sh       |   14 +++++++++++++-
>  test-bin-wrapper.sh |   12 ++++++++++++
>  4 files changed, 57 insertions(+), 12 deletions(-)
>  create mode 100644 test-bin-wrapper.sh

I am strongly opposed to a patch this big, just for something as 3rd class 
as CVS server faking.  We already have a big fallout from all that bending 
over for Windows support, and I do not like it at all.

Note: I do not even have to look further than the diffstat to see that it 
is wrong.

The point is: if cvsserver wants to pretend that it is in a fake bin where 
almost none of the other Git programs are, fine, let's do that _in the 
test for cvsserver_.

Let's not fsck up the whole test suite just for one user.

Ciao,
Dscho