From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 20 Jan 2009 13:51:49 GMT
Subject: valgrind patches, was Re: What's cooking in git.git (Jan 2009, #04; Mon, 19)
Message-ID: <alpine.DEB.1.00.0901201447290.5159@intel-tinevez-2-302>
In-Reply-To: <20090120044447.GF30714@sigill.intra.peff.net>

Hi,

On Mon, 19 Jan 2009, Jeff King wrote:

> One of the things I didn't like about it was that the valgrind wrapper 
> directory was created in the Makefile.

I agree.

> I think creating it inside the trash directory for each test run that 
> wants to use valgrind makes more sense (probably as .git/valgrind, which 
> is unlikely to hurt anything but will stay out of the way of most of the 
> tests).

Here I disagree.  But I think that test-lib.sh should create it on-demand, 
and it should traverse all executables in all paths listed in $PATH, 
replacing the ones that start with "git-" ("git" itself should be the 
first one) that are no scripts by symlinks to the valgrind script (which 
should therefore live in t/), and those that _are_ scripts by symlinks to 
$GIT_ROOT/$NAME.

I'll work on it.

Ciao,
Dscho