From: Johannes Schindelin Date: Mon, 19 Jan 2009 01:24:23 GMT Subject: Re: [PATCH 2/3] Teach read_tree_recursive() how to traverse into submodules Message-ID: In-Reply-To: <8c5c35580901181446n3c36a345m5d8e78764a85c123@mail.gmail.com> Hi, On Sun, 18 Jan 2009, Lars Hjemli wrote: > Sorry, but if your concern is whether to traverse a submodule in a bare > repo when the submodule isn't checked out (yeah, contradiction in > terms), I just don't see the point. Obviously. > For non-bare repositories the policy has always been to ignore > submodules which isn't checked out, but for bare repositories there is > no obvious way (for me, at least) to apply the same policy. There is one: we never traverse them in bare repositories. Never. You are introducing that contradicts that on purpose. Which I do not like at all. Sure, what you want is a nifty feature, but you'll have to do it right. For example, your handling for bare repositories precludes everybody from specifying -- just for this particular call to git archive -- what submodules they want to include. And you preclude anybody from excluding -- just for this particular call to git archive -- certain submodules whose commits just so happen to be present in the superproject. For me, that is a sign of a bad user interface design. Ciao, Dscho P.S.: if you still don't get the point, I will just shut up, until the question crops up, and redirect every person confused by that behavior to you. Be prepared.